search

arishuynhvan / SPi-Reader

Web-based IDE for Sonic Pi designed for accessibility
GNU General Public License v3.0
3 stars 1 forks source link

Recording #19

Closed ravishwetha closed 7 years ago

ravishwetha commented 7 years ago

On this branch, the save and load buttons are start and stop record buttons, just to test out the functionality. We can reroute the methods to the proper places on your UI revamp. Other than that, all changes have been in the control.js and two ruby client files.

Recording: start, stop and save works but there are limitations:

Recordings are saved in the documents folder under home by default and if the user deletes it, the recording can't save at all. I tried relative paths using '../' but it causes issues for an unknown reason and does not save the file either.

I can change the code to add custom file names quite quickly once we have the GUI portion for the user to enter that. For now, the name is given using the date.getTime() method (milliseconds since 1/1/1970).

Visually impaired users can accidentally make the recording longer than it needs to be by missing the stop recording button, I made it so that the buffer automatically plays when start record button is pressed but the user has free reign on when recording stops, even when the music is long over. I'm not yet sure how to make it so that stop recording is called immediately when the music stops.

ravishwetha commented 7 years ago

Can use the branch as it is to test out the functionality, but need to change back buttons Save and Load to call their original functions before merging.