Closed n1cn0c closed 8 years ago
Can one of the admins verify this patch?
Hi, Did you have any questions? Do you want us to do a code review?
Hi John. Please review the code and merge it into your develop branch. After that we would like to contribute even more because we need a few features that are not implemented yet. We've also started to get in touch with Arista Professional Services.
Hi Nick, We code reviewed the change and were wondering if the change belongs in the BaseInterface class? What was the reason for adding the "module ET_PO_loadinterval"?
Thanks, John
Hi John,
you are right. It does not makes sense to write an own module. I thought load-interval is not needed on a vxlan interface but I checked it and it is configurable. I'll change it and come back to you soon.
Thanks, Nick
Hi John,
I have changed my commits and added the load-interval function in BaseInterfaceClass. Please verify my changes.
Thanks, Nick
Test this please
CI ran successfully when manually kicked. I'll debug why it didn't auto-run, separately.
This pull request includes methods to set/modify load_interval on ethernet interfaces, portchannel interfaces and ip interfaces.