search

arista-eosplus / rbeapi

Ruby client for Arista eAPI
BSD 3-Clause "New" or "Revised" License
16 stars 16 forks source link

add the ip host function for static dns entries. #164

Closed mmailand closed 7 years ago

eosplus-jenkins commented 7 years ago

Can one of the admins verify this patch?

jerearista commented 7 years ago

Please change the ipaddress option to a list and change the regexes to capture multiple IP addresses.

mmailand commented 7 years ago

Hi, I think I have to change more, because multiple IPs cannot represented by a single string, eg '2.2.2.2 1.1.1.1 3.3.3.3', because the EOS is sorting the IPs to '1.1.1.1 2.2.2.2 3.3.3.3' Therefore I think it should be an Array. And in the puppet-eos module we will sort the user input and send it down to the rbeapi. Then we should get it idempotent. Is that the right way?

jerearista commented 7 years ago

Yes. That method works well.

mmailand commented 7 years ago

Hi Jere, I updated the pull request.

jerearista commented 7 years ago

Jenkins, test this please