Closed shermdog closed 7 years ago
Can one of the admins verify this patch?
@jerearista This could have some backwards compat issues if folks are checking the output == false, but IMO, this is far more valuable.
Jenkins, test this please
@jerearista How did jenkins feel about this?
This impacts the following:
I will verify against our aristanetworks/eos module, too.
For the record, this is a really good enhancement once we make sure we don't negatively impact anything else.
https://github.com/arista-eosplus/puppet-eos module tests pass with this change
Closing for now. Agreed to move this to 2.0
Previously configure would only return false on failure, which is not overly useful. This commit includes the exception itself
Additionally CommandError now includes the err from the device.
This makes output in higher level tools far more actionable: