search

arista-eosplus / rbeapi

Ruby client for Arista eAPI
BSD 3-Clause "New" or "Revised" License
16 stars 16 forks source link

Update stp.rb #176

Open nicholas-lawrence opened 6 years ago

nicholas-lawrence commented 6 years ago

Regex match doesn't work when using spanning tree mode rapid-pvst. Match is wrong. Puppet errors with Nil class. Fix is to match hyphen.

eosplus-jenkins commented 6 years ago

Can one of the admins verify this patch?

jerearista commented 6 years ago

Jenkins, test this please

jerearista commented 6 years ago

@nicholas-lawrence Thanks for the PR. Could you provide the EOS version and a sample config line which requires this change? This change may require an EOS version check, if the output being parsed has changed.

Thanks.

nicholas-lawrence commented 6 years ago

Hi there, this was doing is on both software versions - I upgraded to see if it would fix it but to no avail. Arista DCS-7050SX2-72Q-R

EOS-4.19.5M and EOS-4.19.6.3M

The puppet manifest we use is with hiera - but even if we just used a simple one calling spanning-tree port fast or bpduguard it would error.

eos_stp_interface { et1: portfast => enable, bpduguard => enable, }

Please let me know what else you need.

Thank you

Nicholas

On 24 May 2018 at 05:15, Jere Julian notifications@github.com wrote:

@nicholas-lawrence https://github.com/nicholas-lawrence Thanks for the PR. Could you provide the EOS version and a sample config line which requires this change? This change may require an EOS version check, if the output being parsed has changed.

Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arista-eosplus/rbeapi/pull/176#issuecomment-391582672, or mute the thread https://github.com/notifications/unsubscribe-auth/Alp0EmlXfagVnXu97bNjJcqq8JC8AylCks5t1jPTgaJpZM4UGsDa .

jakegroves commented 5 years ago

@eosplus-jenkins and @jerearista when is this fix going to be merged into mainstream? Been waiting on this fix for a while now.