Some issues (unrelated to this piece of code) have demonstrated that it is necessary to actually relax the test to check if tools_cv.py receives an encrypted VAULT password.
Rather than raising if the password is not a string, raise only if the password is a dict that containt the __ansible_vault key. More specific and better.
Fix the documentation to reflect that this should not be an issue anymore in recent versions of ansible.
Update the error message as well
Component(s) name
arista.cvp.plugins
Proposed changes
Cf summary changes
How to test
Run the test suite one test added
Checklist
Repository Checklist
[x] My code has been rebased from devel before I start
Some issues (unrelated to this piece of code) have demonstrated that it is necessary to actually relax the test to check if
tools_cv.pyreceives an encrypted VAULT password.Btw this should happen less and less because ansible has fixed the issue in all train in: https://github.com/ansible/ansible/pull/78236
Change Summary
Rather than raising if the password is not a string, raise only if the password is a dict that containt the
__ansible_vaultkey. More specific and better.Fix the documentation to reflect that this should not be an issue anymore in recent versions of ansible.
Update the error message as well
Component(s) name
arista.cvp.pluginsProposed changes
Cf summary changes
How to test
Run the test suite one test added
Checklist
Repository Checklist