aristanetworks / ansible-cvp

Ansible modules for Arista CloudVision
http://cvp.avd.sh
Apache License 2.0
66 stars 61 forks source link

Unhelpful error message when trying to deploy configs for a nonexisting device #578

Closed ClausHolbechArista closed 1 year ago

ClausHolbechArista commented 1 year ago

Issue Summary

Unhelpful error message when deploying configs to a nonexisting device

Which component(s) of AVD impacted

cv_device_v3

How do you run AVD ?

Ansible CLI with AVD Runner

Input variables

No response

Steps to reproduce

Add a nonexisting device to the AVD inventory but do _not_ set `is_deployed: false`

Relevant log output

warnings.warn(
/home/g96568-udm/.local/lib/python3.9/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host 'i-cvp.infra.oneadr.net'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
  warnings.warn(
Traceback (most recent call last):
  File \"/home/g96568-udm/.ansible/tmp/ansible-local-3270975mc1oork9/ansible-tmp-1674725587.0243366-3272352-48104904724507/AnsiballZ_cv_device_v3.py\", line 107, in <module>
    _ansiballz_main()
  File \"/home/g96568-udm/.ansible/tmp/ansible-local-3270975mc1oork9/ansible-tmp-1674725587.0243366-3272352-48104904724507/AnsiballZ_cv_device_v3.py\", line 99, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File \"/home/g96568-udm/.ansible/tmp/ansible-local-3270975mc1oork9/ansible-tmp-1674725587.0243366-3272352-48104904724507/AnsiballZ_cv_device_v3.py\", line 47, in invoke_module
    runpy.run_module(mod_name='ansible_collections.arista.cvp.plugins.modules.cv_device_v3', init_globals=dict(_module_fqn='ansible_collections.arista.cvp.plugins.modules.cv_device_v3', _modlib_path=modlib_path),
  File \"/usr/lib64/python3.9/runpy.py\", line 225, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File \"/usr/lib64/python3.9/runpy.py\", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File \"/usr/lib64/python3.9/runpy.py\", line 87, in _run_code
    exec(code, run_globals)
  File \"/tmp/ansible_arista.cvp.cv_device_v3_payload_bt6qth8k/ansible_arista.cvp.cv_device_v3_payload.zip/ansible_collections/arista/cvp/plugins/modules/cv_device_v3.py\", line 262, in <module>
  File \"/tmp/ansible_arista.cvp.cv_device_v3_payload_bt6qth8k/ansible_arista.cvp.cv_device_v3_payload.zip/ansible_collections/arista/cvp/plugins/modules/cv_device_v3.py\", line 252, in main
  File \"/tmp/ansible_arista.cvp.cv_device_v3_payload_bt6qth8k/ansible_arista.cvp.cv_device_v3_payload.zip/ansible_collections/arista/cvp/plugins/module_utils/device_tools.py\", line 1158, in manager
  File \"/tmp/ansible_arista.cvp.cv_device_v3_payload_bt6qth8k/ansible_arista.cvp.cv_device_v3_payload.zip/ansible_collections/arista/cvp/plugins/module_utils/device_tools.py\", line 590, in __state_present
  File \"/tmp/ansible_arista.cvp.cv_device_v3_payload_bt6qth8k/ansible_arista.cvp.cv_device_v3_payload.zip/ansible_collections/arista/cvp/plugins/module_utils/device_tools.py\", line 527, in __refresh_user_inventory
  File \"/tmp/ansible_arista.cvp.cv_device_v3_payload_bt6qth8k/ansible_arista.cvp.cv_device_v3_payload.zip/ansible_collections/arista/cvp/plugins/module_utils/device_tools.py\", line 1029, in refresh_systemMacAddress
KeyError: 'systemMacAddress'

Code of Conduct