Closed ClausHolbechArista closed 1 year ago
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
@ClausHolbechArista Question:
inventory_mode: loose
, there is no warning message in the return data structure that warns the user that one of the missing device was ignored. This might be useful to add to give user feedback about what passed and what didn't. @ClausHolbechArista Question:
- when we have
inventory_mode: loose
, there is no warning message in the return data structure that warns the user that one of the missing device was ignored. This might be useful to add to give user feedback about what passed and what didn't.
I agree that we could give the user some information, and I will add that. But I don't think it should be a warning, since the user specifically configured the loose mode (they expect some devices to be missing). So I suggest to add it as info-level output.
Change Summary
Add "inventory_mode" to allow ignoring missing devices
Related Issue(s)
Fixes #579
Component(s) name
arista.cvp.cv_device_v3
Proposed changes
inventory_mode
: Define how missing devices are handled.loose
: Ignore missing devices.strict
(default): Fail on any missing device.How to test
Tested manually.
With default
inventory_mode: strict
:With
inventory_mode: loose
:Checklist
User Checklist
Repository Checklist