aristanetworks / ansible-cvp

Ansible modules for Arista CloudVision
http://cvp.avd.sh
Apache License 2.0
65 stars 61 forks source link

Apply image on multiple devices #620

Closed sugetha24 closed 5 months ago

sugetha24 commented 1 year ago
The test is always with only one device in the inventory so we never tests what happens if we have multiple devices and the first one fails (currently the behavior can be either to skip it (if the first device is in the undefined container)  or to fail_json (if the bundle name is not valid or if `apply_image_to_element` raise an error hence stopping the loop) depending on the error). 
I am not sure what is the expected behavior there (which I agree is not part of this PR but maybe would warrant some future refactoring).

the behavior is then weird as if I have 10 devices and the first one raises then none of the other devices get a potential valid bundle applied but if the first 9 are succesful and the last one fails then I get an error message and I am not even told that the 9 others are successful.

_Originally posted by @gmuloc in https://github.com/aristanetworks/ansible-cvp/pull/590#discussion_r1165210625_

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days