aristanetworks / anta

What do you call an ant with frogs legs?
https://anta.arista.com/
Apache License 2.0
51 stars 26 forks source link

refactor(anta): Change TestStatus to be an Enum for coding clarity #758

Closed gmuloc closed 2 months ago

gmuloc commented 3 months ago

Description

In #740 we end up doing getargs(TestStatus) on a Literal type which feels very awkward. This PR defines a proper type for TestStatus based on built-in Python Enum (can be made better in Python 3.11 with StrEnum)

Checklist:

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 months ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud