aristanetworks / anta

What do you call an ant with frogs legs?
https://anta.arista.com/
Apache License 2.0
46 stars 24 forks source link

fix(anta): Remove JSON output when saving to a file #800

Closed carl-baillargeon closed 2 weeks ago

carl-baillargeon commented 3 weeks ago

Description

When using the CLI command anta nrfu json --output ./results.json, results will be saved in a JSON file without printing to the console.

Fixes #760

Checklist:

carl-baillargeon commented 2 weeks ago

LGTM - maybe need to mark the PR as a breaking change?

Not sure.. The basic usage without --output remains unchanged and the new bahavior is more consistent with common CLI patterns (where specifying an output file often implies redirecting output away from stdout) so it could be considered as a fix/bug.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud