aristanetworks / anta

What do you call an ant with frogs legs?
https://anta.arista.com/
Apache License 2.0
46 stars 24 forks source link

Bug: Remove VerifyLLDPNeighbors Failure Message Newlines #816

Closed kpbush30 closed 1 week ago

kpbush30 commented 2 weeks ago

Identified this bug through the use of AVD validate state, when VerifyLLDPNeighbors connectivity test fails, the reporting markdown is broken due to new lines injected into table.

This could be solved in AVD by stripping newline before placing in report, but verified the failure message for VerifyLLDPNeighbors is not consistent with other ANTA failures. Looks like fix is to return failures list of dicts similar to VerifyReachability.

https://github.com/aristanetworks/anta/blob/main/anta/tests/connectivity.py#L173-L179

gmuloc commented 2 weeks ago

Hi @kpbush30 I think this may be a duplicate from https://github.com/aristanetworks/anta/issues/752 Can you confirm if upgrading AVD solves your issue?

kpbush30 commented 1 week ago

@gmuloc - you are right, my mistake, my environment had downgraded to 4.8.0. Validated this is fixed 4.10.0

Apologies, thank you for the response!