aristanetworks / anta

What do you call an ant with frogs legs?

https://anta.arista.com/

Apache License 2.0

52 stars 26 forks source link

fix(anta)!: Make multiple tags filtering work properly (and fall pytest cleaning) #827

Closed mtache closed 1 month ago

mtache commented 1 month ago

This PR started as a PR to Refactor pytest tests, and (wo)man it did

but here what's included:

Refactor of fixtures, tests
Reordering of fixtures
Also disable various pylint rules implemented in Ruff and mypy - which led to new tests being needed
new tests
mocking with respx
doc updates
doc cleaning

and more importantly several fixes among which:

make multiple tags filter work: before that when multiple filters were given, all tests from all matching tags were run on all devices and the world was sad.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have run pre-commit for code linting and typing (pre-commit run)
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes (tox -e testenv)

gmuloc commented 1 month ago

PR needs new tests to pass SonarCloud - will check it on Monday

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
85.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud