search

aristanetworks / avd-workshops

Arista Automation Workshop
https://aristanetworks.github.io/avd-workshops/
18 stars 24 forks source link

Doc: Remove Create a GitHub personal access token #127

Closed carlbuchmann closed 6 months ago

carlbuchmann commented 6 months ago

This is no longer required as the labs are now using a one-time token https://aristanetworks.github.io/avd-workshops/git/#create-a-github-personal-access-token

carlbuchmann commented 6 months ago

Please assign @philippebureau

JulioPDX commented 6 months ago

@MitchV85 Any issues here? We've had instances where students think they need to create this as they go through the lab within the ATD

mjbear commented 6 months ago

@JulioPDX

My two cents as a student, although there is a Note just before the token section it is easy to get sucked into the bold headings. :man_shrugging: I would suggest additionally adding a note in the section itself so it's reinforced that step is not needed for the lab IDE.

Additionally I would suggest retaining the token write up, but making it a collapsed section. Thoughts?

Here's my take on it in PR #135

MitchV85 commented 6 months ago

@JulioPDX and @carlbuchmann - No issues here. If the token is no longer necessary for the workshops, then let's remove the section about how to create one. We will leave the admonition in place that calls out the need to create a token if not using the ATD environment.

Let's go ahead and remove

JulioPDX commented 6 months ago

This is fixed in a PR in flight. Thank you all for the comments

mthiel117 commented 6 months ago

fixed #135