aristanetworks / avd-workshops

Arista Automation Workshop
https://labguides.testdrive.arista.com
21 stars 29 forks source link

Docs: avd-lab-guide.md - simplify the expression used to set LABPASSPHRASE #148

Closed mjbear closed 3 months ago

mjbear commented 7 months ago

Hello Arista Engineering people,

Mr. T asked me to put in issues before I open up PRs. I fully intend to open up PRs once suggestions are agreed upon. :sunglasses:

In both avd-lab-guide.md and cicd-basics.md there is an expression (piped shell commands) used to retrieve the LABPASSPHRASE from config.yaml. I have a suggestion that simplifies it greatly to exclusively an awk command.

Are you good with me submitting this as a PR?

Thank you!

JulioPDX commented 7 months ago

Oh yeah, that shortcut is not set in stone. Anything to simplify process is a good thing!

mjbear commented 7 months ago

Submitted PR #152

JulioPDX commented 3 months ago

Fixed in #152