aristanetworks / avd-workshops

Arista Automation Workshop
https://aristanetworks.github.io/avd-workshops/
21 stars 29 forks source link

Docs: avd-lab-guide.md - grammar and line number references #150

Closed mjbear closed 3 months ago

mjbear commented 7 months ago

Hello Arista Engineering people,

Along with #148 and #149...

There are two grammatical and content related items in avd-lab-guide.md I'd like to bring up for discussion. Based on the outcome of our discussion I will submit a PR to cover the approved items. Thank you.

  1. Change "Login to" to "Log into"

  2. The line numbers no longer exactly correlate. Should the line number reference be updated or changed to a relative statement?

  3. Similar to item 2, the line number is no longer accurate.

JulioPDX commented 7 months ago

Oh wow, I love your appreciation for good grammar. Login, log into, log in. Please go ahead and submit a PR for all of these items. I messed up the line numbering when I added the mlag config portions for same subnet.

mjbear commented 7 months ago

My school grammar teachers left a mark on me, haha.

All good. If the line numbers continue to change we might consider referencing the line based on the relative position.

Examples:

mjbear commented 7 months ago

Submitted PR #152

JulioPDX commented 3 months ago

Fixed in #152