Closed mjbear closed 3 months ago
Oh wow, I love your appreciation for good grammar. Login, log into, log in. Please go ahead and submit a PR for all of these items. I messed up the line numbering when I added the mlag config portions for same subnet.
My school grammar teachers left a mark on me, haha.
All good. If the line numbers continue to change we might consider referencing the line based on the relative position.
Examples:
- group: RACK2
Submitted PR #152
Fixed in #152
Hello Arista Engineering people,
Along with #148 and #149...
There are two grammatical and content related items in avd-lab-guide.md I'd like to bring up for discussion. Based on the outcome of our discussion I will submit a PR to cover the approved items. Thank you.
Change "Login to" to "Log into"
The line numbers no longer exactly correlate. Should the line number reference be updated or changed to a relative statement?
sites/site_1/group_vars/SITE1_FABRIC.yml
.Similar to item 2, the line number is no longer accurate.
RACK3
is the same asRACK2
, which can be found on line 52