aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
290 stars 210 forks source link

Add Storm Control to Port Channel Interfaces Cli config gen #1066

Closed ernestoherrerab closed 3 years ago

ernestoherrerab commented 3 years ago

Issue Type

Is your feature request related to a problem? Please describe. Sort of, we are migrating to EVPN/VXLAN and some of our existing Port Channels are using storm control and this would facilitate their migration.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

It is easier to implement commands on the port channel directly instead of on individual interfaces (which might not even be supported)

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] There is no structured data in the port_channel_interfaces on the cli config gen

Describe the solution you'd like

Add the same keys for storm control as the one available for ethernet_interfaces

A clear and concise description of what you want to happen. Add the below to port_channel_interfaces

storm_control:
  all:
    level: < Configure maximum storm-control level >
    unit: < percent* | pps (optional and is hardware dependant - default is percent)>
  broadcast:
    level: < Configure maximum storm-control level >
    unit: < percent* | pps (optional and is hardware dependant - default is percent)>
  multicast:
    level: < Configure maximum storm-control level >
    unit: < percent* | pps (optional and is hardware dependant - default is percent) >
  unknown_unicast:
    level: < Configure maximum storm-control level >
    unit: < percent* | pps (optional and is hardware dependant - default is percent)>

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

ankudinov commented 3 years ago

duplicate of #154

ClausHolbechArista commented 3 years ago

So this turned out to be missing documentation. Lost somewhere since #154 got implemented.