aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
299 stars 220 forks source link

Feat(eos_designs): Add router general router-id ipv4 knob #1245

Closed lermilov closed 2 weeks ago

lermilov commented 3 years ago

Enhancement summary

Starting EOS 4.22.1F (https://eos.arista.com/eos-4-22-1f/general-router-id/) we support to set global router-id which can inherited to all BGP VRFs. Currently, AVD add router-id knob per VRF, which is suboptimal comparing to single global router-id config.

Which component of AVD is impacted

eos_designs, eos_cli_config_gen

Use case example

Less config within VRF, best practice from EOS perspective

Describe the solution you would like

Add eos-designs variable to enable using router general router-id ipv4 knob

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

lermilov commented 3 years ago

Please assign it to me

ClausHolbechArista commented 3 years ago

Implement a fabric variable use_router_general_for_router_id: < true | false | default -> false >