aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
279 stars 202 forks source link

Feat(eos_designs): PTP uplink selection #3029

Open nielsjlarsen opened 1 year ago

nielsjlarsen commented 1 year ago

Enhancement summary

It should be possible to select which uplinks PTP is enabled on, using generic specifications, to minimise the load on the device.

Which component of AVD is impacted

eos_designs

Use case example

Currently when PTP is enabled, PTP is enabled on all leaf/spine links. This works well in a network design using fixed form factor switches with not that many ports. But, when using a modular chassis like a 7816 filled with line cards and leaf switches all use 8x100G uplinks, the load on the spine to generate PTP messages across all those links is too much.

Describe the solution you would like

nodetype (e.g. l3leaf):
  defaults:
    ptp_uplink_interfaces: [ <local_switch_interface1>, <local_switch_interface2>, ... ]

or:

node:
 ptp_uplink_interfaces: [ <local_switch_interface1>, <local_switch_interface2>, ... ] 

The above should override the default behaviour which must remain the current behaviour (enable it on all uplinks)

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

ClausHolbechArista commented 1 year ago

Could we add some more abstraction here to set the number of uplinks you want PTP on, and then stagger the selected interfaces?

ptp_max_uplinks: 2          # Enable PTP on up to two uplinks
ptp_staggered_uplinks: true # Offset which uplinks PTP is enabled on based on ID

So with 8 uplinks: id:1 -> uplink1 & uplink5 id:2 -> uplink2 & uplink6 id:3 -> uplink3 & uplink7 id:4 -> uplink4 & uplink8 id:5 -> uplink1 & uplink5

Or with 3 uplinks: id:1 -> uplink1 & uplink2 id:2 -> uplink1 & uplink3 id:3 -> uplink2 & uplink3 id:4 -> uplink1 & uplink2

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed