aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
295 stars 212 forks source link

Add support for asdot bgp notation in the design config #3659

Open colinmacgiolla opened 8 months ago

colinmacgiolla commented 8 months ago

Enhancement summary

EOS defaults to asplain notation, while accepting both asplain and asdot. If the customer is using asdot + using the ASN notation as indicators of location, etc. the asplain notation makes this meaningless

Which component of AVD is impacted

eos_designs, eos_cli_config_gen

Use case example

User configures, for example bgp_asn: 65123:0043, indicating DC123, rack43 in their schema, but EOS by default would render that as 273678 which is meaningless.

Describe the solution you would like

Allow the user to indicate, for example:

bgp_asn_notation: <asdot | asplain (default) >

in eos_designs

Describe alternatives you have considered

No response

Additional context

https://www.arista.com/en/support/toi/eos-4-22-0f/14237-4-byte-asdot-notation-support

Contributing Guide

ClausHolbechArista commented 8 months ago

Related/overlapping with #1832. In eos_designs I think we should auto-detect asdot notation if the router's own AS is using that. This might change some existing deployments (hence 5.0 territory), so a knob to force the behavior is also needed.

gmuloc commented 8 months ago

Reopening as not implemented

colinmacgiolla commented 8 months ago

Reopening as not implemented

Sorry - misundersood come of the context for #1832

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed