aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
255 stars 190 forks source link

Feat(eos_designs): add option for ip igmp snooping fast-leave #3942

Closed pvinci-arista closed 1 week ago

pvinci-arista commented 2 months ago

Enhancement summary

Add key to enable ip igmp snooping vlan fast-leave when

evpn_l2_multicast: 
  enabled:  true

is configured

Which component of AVD is impacted

eos_designs

Use case example

When deploying l2 multicast, configuration stanzas are issued for:

ip igmp snooping vlan 1234 querier
ip igmp snooping vlan 1234 querier address 1.2.3.4

There is a need to add ip igmp snooping vlan 1234 querier

Describe the solution you would like

Add the key fast-leave to the existing tenant configuration:

            igmp_snooping_querier:
              # Will be enabled automatically if "evpn_l2_multicast" is enabled.
              enabled: < true | false | default false >
              source_address: < ipv4_address -> default ip address of Loopback0 >
              version: < 1, 2, 3 -> default 2 (EOS) >

Describe alternatives you have considered

We can generate the configuration with:

            eos_cli: |
              ip igmp snooping vlan 123 fast-leave
              ip igmp snooping vlan 1234 querier version 3
              ip igmp snooping vlan 1234 fast-leave

Additional context

No response

Contributing Guide

ClausHolbechArista commented 1 month ago

I think we should add the fast_leave: <bool> option under both evpn_l2_multicast and allow it to be overridden under the deeper igmp_snooping_querier models.