Bug(eos_designs) `redistribute connected` not under address_family ipv4 for default vrf

pvinci-arista commented 4 months ago

Issue Summary

When bgp_default_ipv4_unicast : false, which is the default, the redistribute connected should be in the address-family ipv4 stanza instead of the default.

router bgp 65535
   bgp asn notation asdot
   router-id 1.2.3.4
   no bgp default ipv4-unicast
   ... <neighbor info>...
   redistribute connected    <-- 
   !
   address-family ipv4
      neighbor IPv4-UNDERLAY-PEERS activate
                                               <-- missing

Which component(s) of AVD impacted

eos_designs

How do you run AVD ?

Ansible CLI (with virtual-env or native python)

Steps to reproduce

This was discovered while trying to redistribute SVIs in the default vrf.

An enhancement can be found here:  https://github.com/aristanetworks/avd/issues/3928

Relevant log output

No response

Contributing Guide

[X] I agree to follow this project's Code of Conduct

ClausHolbechArista commented 3 months ago

I am not sure this is completely correct. It has been like this for a very long time, so I think we need to revisit this on the EOS side and decide.

gmuloc commented 1 month ago

@pvinci-arista can you take a look at Claus comment and reevaluate this issue?

aristanetworks / avd