Refactor(plugins): Move jinja filter code for arista.avd.convert_dicts to PyAVD

aristanetworks / avd

Arista Validated Designs

https://avd.arista.com

Apache License 2.0

251 stars 187 forks source link

Refactor(plugins): Move jinja filter code for arista.avd.convert_dicts to PyAVD #4069

Closed Vibhu-gslab closed 3 weeks ago

Vibhu-gslab commented 4 weeks ago

Change Summary

Move jinja filter code for arista.avd.convert_dicts to PyAVD

Related Issue(s)

Fixes #4072

Component(s) name

Filter

convert_dict

Proposed changes

Move convert_dict code to PyAVD.

How to test

CI should catch things.

Checklist

User Checklist

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 4 weeks ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4069
# Activate the virtual environment
source test-avd-pr-4069/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@convert_dict_filter#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,convert_dict_filter --force
# Optional: Install AVD examples
cd test-avd-pr-4069
ansible-playbook arista.avd.install_examples

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud