Refactor(eos_cli_config_gen): Addressed missed comments for patch-panel

aristanetworks / avd

Arista Validated Designs

https://avd.arista.com

Apache License 2.0

285 stars 202 forks source link

Refactor(eos_cli_config_gen): Addressed missed comments for patch-panel #4078

Closed gmuloc closed 3 months ago

gmuloc commented 3 months ago

Change Summary

Fix comments that were added in patch-panel PR #4063

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add max values and group together min and max delay in reco

How to test

molecule

Checklist

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 3 months ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4078
# Activate the virtual environment
source test-avd-pr-4078/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@address-4063-comments#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,address-4063-comments --force
# Optional: Install AVD examples
cd test-avd-pr-4078
ansible-playbook arista.avd.install_examples

gmuloc commented 3 months ago

@Shivani-gslab @ccsnw @ClausHolbechArista

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Shivani-gslab commented 3 months ago

https://github.com/aristanetworks/avd/pull/4078/files#diff-04eafc9714c156e4b9d33497f8abe2ff613613dee60edb095bbea33afd8b7c76L23-R26 this part of schema can be reduced to - recovery_review_delay

recovery_review_delay:
    type: dict
    keys:
        min:
            type: int
        max:
             type: int

Not able to comment on that line :)

gmuloc commented 3 months ago

https://github.com/aristanetworks/avd/pull/4078/files#diff-04eafc9714c156e4b9d33497f8abe2ff613613dee60edb095bbea33afd8b7c76L23-R26 this part of schema can be reduced to - recovery_review_delay
recovery_review_delay:
    type: dict
    keys:
        min:
            type: int
        max:
             type: int
Not able to comment on that line :)

thanks for this comment ! I think we will stick with the schema from the original PR except if more people disagree / want to see it change? @ClausHolbechArista

Shivani-gslab commented 3 months ago

https://github.com/aristanetworks/avd/pull/4078/files#diff-04eafc9714c156e4b9d33497f8abe2ff613613dee60edb095bbea33afd8b7c76L23-R26 this part of schema can be reduced to - recovery_review_delay
recovery_review_delay:
    type: dict
    keys:
        min:
            type: int
        max:
             type: int
Not able to comment on that line :)
thanks for this comment ! I think we will stick with the schema from the original PR except if more people disagree / want to see it change? @ClausHolbechArista

Other than this, LGTM