Fix: Adjust inventory group names in molecule tests to follow Ansible guidelines

MaheshGSLAB commented 3 weeks ago

Change Summary

Addressed group name warning in ansible when running molecule.

Related Issue(s)

Fixes #3270

Component(s) name

arista.avd.eos_designs

Proposed changes

Changed the group name as capital and updated hyphen with underscore.

How to test

Run molecule

Checklist

User Checklist

[x] Verified the changes by running pre-commit and all molecules.
[x] Implemented only those commands whose output is seen on show running-config command.
[ ] Along with EOS config template, updated the documentation template as well.
[ ] Add the test-case in molecules.
[ ] Tested the generated config through eapi or cvp on lab.
[ ] Added meaningfully variable names.
[ ] Added description only if they provide extra information apart from the key.
[x] Do not using helping words in description.
[ ] Added punctuation to all descriptions.
[ ] One row per entry (per primary key) for documentation template.
[ ] If making any key "deprecated", Make sure to move tests with this to the deprecated_vars molecule and make sure to add a test if we are missing it .
[ ] Use ` for key names in description. eg.name`.
[ ] Use plural key names if it has multiple elements like- sample_policies.
[ ] Try to keep less indented j2 code.
[ ] Used natural sort for "for loops" in j2 templates (after checking on EOS CLI).
[ ] If checking child key avoid checking parent key before it (arista.avd.defined).
[ ] Do not show passwords and password type in documents. Hide it using 'arista.avd.hide_passwords' filter. Dont add column for passwords and password type in documents.
[ ] Order of config should be as per EOS cli.
[ ] Add exclamatory marks(!) at correct position in templates. It should be same as reflected in run-config.
[ ] Do not use inline if/else in jinja, since it becomes much harder to read the template.
[ ] Do all possible unit test for config and python code

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 3 weeks ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4097
# Activate the virtual environment
source test-avd-pr-4097/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-3270#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-3270 --force
# Optional: Install AVD examples
cd test-avd-pr-4097
ansible-playbook arista.avd.install_examples