aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
285 stars 202 forks source link

Feat(eos_designs): Add support to enable ISIS authentication at global level #4102

Open laxmikantchintakindi opened 3 months ago

laxmikantchintakindi commented 3 months ago

Change Summary

Add support to enable ISIS authentication at global level.

Related Issue(s)

Fixes #3674

Component(s) name

arista.avd.eos_designs

Proposed changes

ISIS authentication is not enabled by default when enabling ISIS as the underlay protocol for the fabric. It would be great to have a global knob to enable authentication in the fabric links like we do for BGP.

How to test

Add underlay_isis_authentication_mode and underlay_isis_authentication_key at global level.

Checklist

User Checklist

Repository Checklist

github-actions[bot] commented 3 months ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4102
# Activate the virtual environment
source test-avd-pr-4102/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@isis_authentication#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,isis_authentication --force
# Optional: Install AVD examples
cd test-avd-pr-4102
ansible-playbook arista.avd.install_examples
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 3 months ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 3 months ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] commented 3 months ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 3 months ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] commented 3 months ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] commented 3 months ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 3 months ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

laxmikantchintakindi commented 2 months ago

Keeping this in draft untill https://github.com/aristanetworks/avd/pull/4254 is merged.

github-actions[bot] commented 2 months ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 1 month ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

ClausHolbechArista commented 1 month ago

The change for eos_cli_config_gen has been merged now.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 19 hours ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.