aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
251 stars 187 forks source link

Refactor(plugins): Move jinja filter code for arista.avd.add_md_toc to PyAVD #4104

Closed gmuloc closed 2 weeks ago

gmuloc commented 3 weeks ago

Change Summary

Move jinja filter code for arista.avd.add_md_toc to PyAVD

Related Issue(s)

Fixes #

Component(s) name

arista.avd.add_md_toc

Proposed changes

Moving the code and unit tests for arista.avd.add_md_toc filter to PyAVD

How to test

Refactored pytest + things should break

Checklist

Repository Checklist

github-actions[bot] commented 3 weeks ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4104
# Activate the virtual environment
source test-avd-pr-4104/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@add_md_toc_filter#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,add_md_toc_filter --force
# Optional: Install AVD examples
cd test-avd-pr-4104
ansible-playbook arista.avd.install_examples
github-actions[bot] commented 2 weeks ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 weeks ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud