Fix(eos_designs)!: Remove eBGP LAN outbound route-map for WAN

gmuloc commented 2 weeks ago

Change Summary

The shipped eBGP LAN feature for WAN routers is not working for connected and static redistributed routes inside a VRF as the route-map would not match these routes. Similarly the routes coming from an eBGP peering in any VRF (including default) would be blocked out by the RM-BGP-UNDERLAY-PEERS-OUT route-map.

This PR is a breaking change to fix this situation.

Related Issue(s)

Discovered while working on #3720 and following review comments, separated in its own PR in order to be able to communicate with clarity about the breaking change.

Component(s) name

arista.avd.eos_design

Proposed changes

Removing the outbound route-map for eBGP LAN peers on WAN routers
Editing doc
Adding limitation for eBGP peering in network_services received routes in VRF default that would not be advertised to the WAN.

How to test

molecule + test on existing lab

Checklist

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 2 weeks ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4107
# Activate the virtual environment
source test-avd-pr-4107/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@breaking-ebgp-wan-ha#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,breaking-ebgp-wan-ha --force
# Optional: Install AVD examples
cd test-avd-pr-4107
ansible-playbook arista.avd.install_examples