aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
251 stars 187 forks source link

Refactor(eos_designs): Move eos_designs_facts to PyAVD #4110

Closed ClausHolbechArista closed 2 weeks ago

ClausHolbechArista commented 2 weeks ago

Change Summary

Move eos_designs_facts to PyAVD

Proposed changes

How to test

Checklist

User Checklist

Repository Checklist

github-actions[bot] commented 2 weeks ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4110
# Activate the virtual environment
source test-avd-pr-4110/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/move-logic-for-eos_designs_facts-to-pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/move-logic-for-eos_designs_facts-to-pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4110
ansible-playbook arista.avd.install_examples
github-actions[bot] commented 2 weeks ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 weeks ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud