aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
284 stars 202 forks source link

Creating sub-interface on l3_interface WAN link errors unless wan_carriers is set to trusted #4115

Closed marlons-AristaPS closed 3 months ago

marlons-AristaPS commented 3 months ago

Issue Summary

When creating a sub-interface wan link avd build fails due to error ipv4_acl_in not being set. When setting wan_carriers to trusted config is rendered but without the acl's. If using physical interface (no sub-interface) with wan_carriers set to false config renders correctly with acl's.

Which component(s) of AVD impacted

eos_designs

How do you run AVD ?

Ansible CLI (with virtual-env or native python)

Steps to reproduce

l3_interfaces:
            - name: Ethernet1/9.150
              ip_address: 1.1.1.0/31
              wan_carrier: ISP-1
              wan_circuit_id: 1111
              peer: ISP-router
              peer_interface: Ethernet1/1
              ipv4_acl_in: TEST-IPV4-ACL-IN
              ipv4_acl_out: TEST-IPV4-ACL-OUT

Relevant log output

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible_collections.arista.avd.plugins.plugin_utils.errors.errors.AristaAvdError: 'ipv4_acl_in' must be set on WAN interfaces where 'wan_carrier' is set, unless the carrier is configured as 'trusted' under 'wan_carriers'. 'ipv4_acl_in' is missing on interface 'Ethernet1/9.150'.
fatal: [Router-1 -> localhost]: FAILED! => {"changed": false, "msg": "'ipv4_acl_in' must be set on WAN interfaces where 'wan_carrier' is set, unless the carrier is configured as 'trusted' under 'wan_carriers'. 'ipv4_acl_in' is missing on interface 'Ethernet1/9.150'."}

Contributing Guide