Fix(eos_designs): Address ipv4_acl_in/out not working for WAN l3 subinterfaces

aristanetworks / avd

Arista Validated Designs

https://avd.arista.com

Apache License 2.0

251 stars 186 forks source link

Fix(eos_designs): Address ipv4_acl_in/out not working for WAN l3 subinterfaces #4116

Closed gmuloc closed 2 weeks ago

gmuloc commented 2 weeks ago

Change Summary

The code cannot retrieve properly ACLs on sub interfaces because of the . in the interface name.

Related Issue(s)

Fixes #4115

Component(s) name

arista.avd.eos_designs

Proposed changes

Used the usual separator key for these scenarii.
added molecule test

How to test

molecule

Checklist

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 2 weeks ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4116
# Activate the virtual environment
source test-avd-pr-4116/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4115#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4115 --force
# Optional: Install AVD examples
cd test-avd-pr-4116
ansible-playbook arista.avd.install_examples

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud