Refactor(eos_cli_config_gen): Move eos_cli_config_gen to pyavd

aristanetworks / avd

Arista Validated Designs

https://avd.arista.com

Apache License 2.0

284 stars 202 forks source link

Refactor(eos_cli_config_gen): Move eos_cli_config_gen to pyavd #4117

Closed gmuloc closed 3 months ago

gmuloc commented 3 months ago

Change Summary

Move eos_cli_config_gen to PyAVD

Component(s) name

pyavd

Proposed changes

Move all templates but custom templates to PyAVD

How to test

molecule goes through

Checklist

User Checklist

[x] Need to be able to recompile templates seamlessly while developing introduced a pre-commit hook. Probably need to document how to use it as it has some caveat (e.g. if you make a change, compile via the hook, rollback the change and use pre-commit, nothing happens because no change to j2 as compared to HEAD)

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 3 months ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4117
# Activate the virtual environment
source test-avd-pr-4117/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@move-eos-cli-config-gen-pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,move-eos-cli-config-gen-pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4117
ansible-playbook arista.avd.install_examples

github-actions[bot] commented 3 months ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 3 months ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 3 months ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 3 months ago

Conflicts have been resolved. A maintainer will review the pull request shortly.