Refactor(eos_designs): Move eos_designs Python modules to PyAVD

ClausHolbechArista commented 2 weeks ago

Change Summary

Move eos_designs Python modules to PyAVD

Proposed changes

Move all eos_designs python modules from Ansible collection to PyAVD
- Adjust imports accordingly
Split pylint into an ansible-specific pylintrc and a more standard pylintrc for everything else
- Update pre-commit
- Fix various pylint issues in PyAVD code
Fixed bug for MSDP peerings where the wrong address was being used (clearly visible in our test artifacts!)

How to test

No changes to molecule except the MSDP bugfix.

Checklist

User Checklist

N/A

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 2 weeks ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4120
# Activate the virtual environment
source test-avd-pr-4120/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/move-eos_designs-python-modules-to-pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/move-eos_designs-python-modules-to-pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4120
ansible-playbook arista.avd.install_examples