Feat(eos_designs): Enforce unicity of region IDs and per-region site IDs for CV Pathfinder - Githubissues

aristanetworks / avd

Arista Validated Designs

https://avd.arista.com

Apache License 2.0

251 stars 186 forks source link

Feat(eos_designs): Enforce unicity of region IDs and per-region site IDs for CV Pathfinder #4121

Closed gmuloc closed 1 week ago

gmuloc commented 1 week ago

Change Summary

Leverage unique_keys introduced in #3725 as planned

Component(s) name

arista.avd.eos_designs

Proposed changes

CF schema fragment changes

How to test

Tested locally by triggering conflicting scenario (unique_keys work as expected)

Checklist

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 1 week ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4121
# Activate the virtual environment
source test-avd-pr-4121/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@unique-id-regions-and-sites#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,unique-id-regions-and-sites --force
# Optional: Install AVD examples
cd test-avd-pr-4121
ansible-playbook arista.avd.install_examples

github-actions[bot] commented 1 week ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 1 week ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] commented 1 week ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 1 week ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] commented 1 week ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

carlbuchmann commented 1 week ago

Functionality testing successful. I don't see any documentation being updated, and I would have expected to see -> id: <int; 1-10000; required; unique>

This is captured in the description.