aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
284 stars 202 forks source link

Refactor(plugins): Move jinja filter code for arista.avd.generate_lacp_id to PyAVD #4139

Closed Shivani-gslab closed 3 months ago

Shivani-gslab commented 3 months ago

Change Summary

Move jinja filter code for arista.avd.generate_lacp_id to PyAVD

Related Issue(s)

Fixes #

Component(s) name

Filter -

Proposed changes

Moving the code and unit tests for arista.avd.is_in_filter filter to PyAVD

How to test

CI should catch things.

Checklist

Repository Checklist

github-actions[bot] commented 3 months ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4139
# Activate the virtual environment
source test-avd-pr-4139/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@generate_lacp_id#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,generate_lacp_id --force
# Optional: Install AVD examples
cd test-avd-pr-4139
ansible-playbook arista.avd.install_examples