Feat(eos_validate_state): Added the validation for DPS interface reachability

MaheshGSLAB commented 3 months ago

Change Summary

Added the validation for DPS interface reachability

Related Issue(s)

Fixes #4150

Component(s) name

arista.avd.eos_validate_state

Proposed changes

Added the validation for DPS interface reachability. You will see VerifyReachability tests with DPS interface.

How to test

Run molecule or test on lab having WAN designs

Checklist

User Checklist

[x] Verified the changes by running pre-commit and all molecules.
[ ] Implemented only those commands whose output is seen on show running-config command.
[x] Along with EOS config template, updated the documentation template as well.
[x] Add the test-case in molecules.
[ ] Tested the generated config through eapi or cvp on lab.
[x] Added meaningfully variable names.
[ ] Added description only if they provide extra information apart from the key.
[x] Do not using helping words in description.
[x] Added punctuation to all descriptions.
[ ] One row per entry (per primary key) for documentation template.
[ ] If making any key "deprecated", Make sure to move tests with this to the deprecated_vars molecule and make sure to add a test if we are missing it .
[ ] Use ` for key names in description. eg.name`.
[ ] Use plural key names if it has multiple elements like- sample_policies.
[ ] Try to keep less indented j2 code.
[ ] Used natural sort for "for loops" in j2 templates (after checking on EOS CLI).
[ ] If checking child key avoid checking parent key before it (arista.avd.defined).
[ ] Do not show passwords and password type in documents. Hide it using 'arista.avd.hide_passwords' filter. Dont add column for passwords and password type in documents.
[ ] Order of config should be as per EOS cli.
[ ] Add exclamatory marks(!) at correct position in templates. It should be same as reflected in run-config.
[ ] Do not use inline if/else in jinja, since it becomes much harder to read the template.
[x] Do all possible unit test for config and python code

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 3 months ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4154
# Activate the virtual environment
source test-avd-pr-4154/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4150#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4150 --force
# Optional: Install AVD examples
cd test-avd-pr-4154
ansible-playbook arista.avd.install_examples

github-actions[bot] commented 1 month ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 1 month ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] commented 1 month ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 1 month ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

aristanetworks / avd