aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
251 stars 186 forks source link

Feat(eos_designs): Rename 'ptp' key to 'ptp_settings' to avoid conflicting variable with 'eos_cli_config_gen' #4155

Open laxmikantchintakindi opened 6 days ago

laxmikantchintakindi commented 6 days ago

Change Summary

Rename ptp key to ptp_settings to avoid conflicting variable with eos_cli_config_gen.

Related Issue(s)

Fixes #3236

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

Checklist

User Checklist

Repository Checklist

github-actions[bot] commented 6 days ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4155
# Activate the virtual environment
source test-avd-pr-4155/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@ptp#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,ptp --force
# Optional: Install AVD examples
cd test-avd-pr-4155
ansible-playbook arista.avd.install_examples