Feat(eos_cli_config_gen): Add switchport data model

aristanetworks / avd

Arista Validated Designs

https://avd.arista.com

Apache License 2.0

284 stars 202 forks source link

Feat(eos_cli_config_gen): Add switchport data model #4158

Closed Shivani-gslab closed 1 month ago

Shivani-gslab commented 3 months ago

Change Summary

Refactor eos_cli_config_gen switchport data models

Related Issue(s)

Fixes #2288

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding switchport to ethernet-interfaces and port-channel interfaces schema and template.

Config for switchport.tap and switchport.tool is implemented in PR #4174

Added new schema section for switchport keys.
Updated config and doc template to implement new keys.
Deprecated old keys for switchport.
Updated the documentation template logic to handle the condition for type key.
Updated molecule tests regarding all the changes.

How to test

Molecule tests are added. Test in EOS CLI.

Checklist

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 3 months ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4158
# Activate the virtual environment
source test-avd-pr-4158/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@switchport_trunk#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,switchport_trunk --force
# Optional: Install AVD examples
cd test-avd-pr-4158
ansible-playbook arista.avd.install_examples

ClausHolbechArista commented 2 months ago

Since we are targeting 5.0 now you can deprecate the old models you are replacing. Thanks.

github-actions[bot] commented 2 months ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.