Feat(eos_designs): Add support to add access-groups on l3-interfaces through network-services

laxmikantchintakindi commented 3 months ago

Change Summary

Add support to add access-groups on l3-interfaces through network-services

Related Issue(s)

Fixes #3534 Only address the L3 interfaec but not the SVIs as it was already implemented in https://github.com/aristanetworks/avd/pull/4096.

Component(s) name

arista.avd.eos_designs

Proposed changes

Initial ask

It would be nice when defining a L3 / SVI in network services to also be able to add an access group right there. That was the tags take care of only adding the L3/SVI as it already does but also only add the access group to the devices that need it.

This PR covers the L3 interfaces part in network services - SVIs was done in https://github.com/aristanetworks/avd/pull/4096

How to test

Checklist

User Checklist

N/A

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions[bot] commented 3 months ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4163
# Activate the virtual environment
source test-avd-pr-4163/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@access_groups#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,access_groups --force
# Optional: Install AVD examples
cd test-avd-pr-4163
ansible-playbook arista.avd.install_examples

github-actions[bot] commented 2 months ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 2 months ago

Conflicts have been resolved. A maintainer will review the pull request shortly.