aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
278 stars 201 forks source link

Support for BGP default timers and send-community commands #4218

Open dgonzalez85 opened 2 months ago

dgonzalez85 commented 2 months ago

Enhancement summary

We are looking to remove this commands from the fabric file:

bgp_defaults:
      - timers bgp 5 15
      - neighbor default send-community

And support them as native ansible vars. However this is not supported today via "eos_cli_config_gen" for all neighbours, only for peer-grups:

https://avd.arista.com/4.9/roles/eos_cli_config_gen/docs/input-variables.htmlhttps://avd.arista.com/4.9/roles/eos_cli_config_gen/docs/input-variables.html

peer_groups:

      # Peer-group name.
    - name: <str; required; unique>

      # Key only used for documentation or validation purposes.
      type: <str>
     [...]
       # 'all' or a combination of 'standard', 'extended', 'large' and 'link-bandwidth (w/options)'.
      send_community: <str>

      # BGP Keepalive and Hold Timer values in seconds as string "<0-3600> <0-3600>".
      timers: <str>

We would like support this also under global BGP settings, so it applies to any new peer-groups that are defined.

Which component of AVD is impacted

eos_cli_config_gen

Use case example

Remove bgp_defaults cli commands and use eos_cli_config_gen.

Describe the solution you would like

Support the commands above under bgp general settings also.

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

dgonzalez85 commented 2 months ago

@carlbuchmann opened as requested. thanks

ClausHolbechArista commented 1 month ago

So the request is to add support for generating:

router bgp 65123
   timers bgp 5 15
   neighbor default send-community