aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
298 stars 219 forks source link

Feat(eos_cli_config_gen): Add BFD Slow-Timer Knob #4718

Closed ccsnw closed 1 week ago

ccsnw commented 1 week ago

Change Summary

Adding Slow-Timer knob to BFD config. Fixing two minor typos in existing J2 template (2 space where only 1 space should be used)

Related Issue(s)

Fixes #<N/A>

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding additional knob to configure slow-timer value in BFD

router_bfd:

slow_timer: description: Rate in milliseconds. type: int min: 2000 max: 60000 ## How to test Molecule Test added ## Checklist ### User Checklist - **Have checked eos cli order for command** - Documentation **not** updated (minor knob) ### Repository Checklist - [x] My code has been rebased from devel before I start - [x] I have read the [**CONTRIBUTING**](https://avd.sh/en/latest/docs/contribution/overview.html) document. - [o] My change requires a change to the documentation and documentation have been updated accordingly. - [x] I have updated [molecule CI](https://github.com/aristanetworks/avd/tree/devel/ansible_collections/arista/avd/molecule) testing accordingly. (check the box if not applicable)
github-actions[bot] commented 1 week ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4718
# Activate the virtual environment
source test-avd-pr-4718/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ccsnw/ansible-avd.git@Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ccsnw/ansible-avd.git#/ansible_collections/arista/avd/,Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob --force
# Optional: Install AVD examples
cd test-avd-pr-4718
ansible-playbook arista.avd.install_examples
sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud