aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
298 stars 219 forks source link

CI(eos_cli_config_gen): Refactor eos_cli_config_gen host vars for `daemon_terminattr` #4723

Open laxmikantchintakindi opened 1 week ago

laxmikantchintakindi commented 1 week ago

Change Summary

Refactor eos_cli_config_gen host vars for daemon_terminattr.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Refactor eos_cli_config_gen host vars for daemon_terminattr.

How to test

Checklist

User Checklist

Repository Checklist

github-actions[bot] commented 1 week ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4723
# Activate the virtual environment
source test-avd-pr-4723/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/molecule-3#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/molecule-3 --force
# Optional: Install AVD examples
cd test-avd-pr-4723
ansible-playbook arista.avd.install_examples
sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions[bot] commented 4 days ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 18 hours ago

Conflicts have been resolved. A maintainer will review the pull request shortly.