aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
299 stars 219 forks source link

Refactor(eos_cli_config_gen): Update eos template to validate `type` key defined in `aaa_server_group` model #4748

Open laxmikantchintakindi opened 5 days ago

laxmikantchintakindi commented 5 days ago

Change Summary

Make type key required in aaa_server_group model.

Related Issue(s)

Fixes #4650

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Make type key required in aaa_server_group model.

How to test

Checklist

User Checklist

Repository Checklist

github-actions[bot] commented 5 days ago

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4748
# Activate the virtual environment
source test-avd-pr-4748/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/eos_cli/aaa_server_group_type_key#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/eos_cli/aaa_server_group_type_key --force
# Optional: Install AVD examples
cd test-avd-pr-4748
ansible-playbook arista.avd.install_examples
sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud