aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
290 stars 209 forks source link

Knob to disable dual-primary for MLAG in L3LS #532

Closed onurgashi closed 3 years ago

onurgashi commented 3 years ago

Issue Type

Is your feature request related to a problem? Please describe.

In some cases there are no management links and we should consider this scenario when forming MLAG and rely on the port-channel instead.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

mlag configuration
   domain-id DC1_POD2_LEAF1
   local-interface Vlan4094
   peer-address 10.254.252.1
  ---   peer-address heartbeat 192.169.0.13 vrf MGMT
   peer-link Port-Channel1
  --- dual-primary detection delay 5 action errdisable all-interfaces

We would need to create a knob so it allows us to enable/disable dual-primary over management.

mlag: dual-primary: < true (default) | false >

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

ksator commented 3 years ago

@onurgashi @titom73 I am adding a var dual_primary_detection (default is true) to l3leaf/defaults and l3leaf/node_groups/group and l2leaf/defaults and l2leaf/node_groups/group. already done for l3leaf
This var will be consumed by l3ls role to generate structured conf that will be consumed by cli_config_gen role.
No need to set this var at fabric level as we can set it at l3leaf/defaults and l2leaf/defaults ?

onurgashi commented 3 years ago

Exactly, so we can specify this globally, and also per device if we want to make changes.

ksator commented 3 years ago

done. will add molecule tests and will update doc later on. meanwhile I am submitting a draft PR so this can be reviewed