aristanetworks / cloudvision-ztpaas-utils

Utilities for ZTP as a Service with CloudVision
Apache License 2.0
11 stars 14 forks source link

Script will crash on CVaaS if the device EOS version is in between 4.24 and 4.25.5 #25

Closed mayank-singla001 closed 5 months ago

mayank-singla001 commented 5 months ago

Currently, this is the behavior of the Custom Bootstrap Script 1) for EOS versions <4.24, we can provide eosURL and they will get upgraded to the provided URL 2) for EOS versions >=4.25.5 which is OSLO, everything works fine 3) for EOS versions in b/w 4.24 and 4.25.5, the TA command will fail as there is no -certsconfig in these versions, and also providing eosURL won't do any image upgrade

Currently, eosURL is only used for devices with EOS <4.24 as there is no SysdbHelperUtils there. Here, we need to handle case 3). So, for this we will redefine the behavior of eosURL parameter.

Proposed Solution: We already say that CBS is provided for minimum OSLO versions i.e. 4.25.5, so we expect the users to provide an eosURL parameter with EOS image >=4.25.5 whenever the current EOS version is less than OSLO. Now, instead of checking only for SysdbHelperUtils, we will always check if eosURL parameter is set or not. If it is set, then we always do an image upgrade. If it is not set, things might go wrong as expected.

mayank-singla001 commented 5 months ago

Found that it is an issue in the bootstrap script and not the custom bootstrap script. Closing this.