search

aristanetworks / cloudvision-ztpaas-utils

Utilities for ZTP as a Service with CloudVision
Apache License 2.0
11 stars 14 forks source link

Recommend making configurable files into templates #7

Closed jason-technology closed 1 year ago

jason-technology commented 1 year ago

Since the bootstrap.py file has to be configured, it would be beneficial for some users if the file were a template. For example:

cvAddr = "${cvAddr}" enrollmentToken = "${enrollmentToken}" cvproxy = "${cvproxy}" eosUrl = "${eosUrl}"

Is pretty standard templating language.

This would even be helpful for your own teams while packaging ZTP docker images that dynamically insert the token.

As it is now, I download this file and make the changes listed above then run through templating to apply values. providing it natively as a template would save some users a lot of work. Those modifying it manually still have to modify it manually and it wouldn't add much for them to do.

harshitk-arista commented 1 year ago

Thanks for the suggestion. A jinja template has been added - https://github.com/aristanetworks/cloudvision-ztpaas-utils/blob/main/BootstrapScriptWithToken/bootstrap_template.j2

harshitk-arista commented 1 year ago

Closing this as the template has been added.