aristanetworks / goarista

Fairly general building blocks used in Arista Go code and open-sourced for the benefit of all.
Apache License 2.0
213 stars 68 forks source link

valuelabel doesn't work for non strings #56

Closed kalebris closed 3 years ago

kalebris commented 3 years ago

There are a few metrics in openconfig for example bgp asn along the path of

/network-instances/network-instance[name=(?P.+)]/protocols/protocol[identifier=BGP][name=BGP]/bgp/neighbors/neighbor[neighbor-address=(?P.+)]/state/peer-as

where valuelabel would be handy as it is difficult to join prometheus metrics based on values.

kalebris commented 3 years ago

Created https://github.com/aristanetworks/goarista/pull/57 to work around this.

avi-kumar commented 3 years ago

resolved in https://github.com/aristanetworks/goarista/commit/5051269002d8d1bd096a3bcaccee35eaa50a8b35