aristanetworks / goeapi

Go library for Arista's eAPI command API implementation
BSD 3-Clause "New" or "Revised" License
46 stars 31 forks source link

Return Node on call to Connect() #18

Closed cheynearista closed 6 years ago

cheynearista commented 6 years ago

Addresses issue #9 Most all api calls require a Node instance to perform any functional action on the device. It doesn't make sense to return EapiConnetionEntity from a call to Connect(). Instead, we should return Node.

codecov-io commented 6 years ago

Codecov Report

Merging #18 into develop will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #18      +/-   ##
===========================================
+ Coverage    88.56%   88.59%   +0.03%     
===========================================
  Files           15       15              
  Lines         2011     2017       +6     
===========================================
+ Hits          1781     1787       +6     
  Misses         195      195              
  Partials        35       35
Impacted Files Coverage Δ
client.go 91.86% <100%> (+0.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 978fd1a...d580fb3. Read the comment docs.