Adds deref operation for NeutLocals in the Array.length PrimOp

aristanetworks / purescript-backend-optimizer

Optimizing backend toolkit and modern ECMAScript backend for PureScript

MIT License

201 stars 18 forks source link

Adds deref operation for NeutLocals in the Array.length PrimOp #64

Closed mikesol closed 1 year ago

mikesol commented 1 year ago

Thanks for the review! I addressed all the new comments in my most recent commit.

mikesol commented 1 year ago

I added a new guard and a new test from my Deku hacking.

natefaubion commented 1 year ago

I've pushed what I consider to be more precise tests. In particular, it uses an abstract function to calculate a value in the binding. This causes the binding to analyze as having unknown complexity (it involves arbitrary work due to calling fn), which makes it not want to duplicate it.