search

aristanetworks / sonic

Open source drivers and initialization library for Arista platforms running SONiC
GNU General Public License v2.0
22 stars 30 forks source link

Align get_status_led to expected API #29

Closed vboykox closed 3 years ago

vboykox commented 3 years ago

Signed-off-by: Volodymyr Boyko volodymyrx.boiko@intel.com

The changes are intended to fix the following warnings:

Aug 18 19:23:10.981375 sonic WARNING pmon#psud[37]: Failed to get led status for psu 1
Aug 18 19:23:10.981608 sonic WARNING pmon#psud[37]: Failed to get led status for psu 2
Aug 18 19:23:13.983173 sonic WARNING pmon#psud[37]: Failed to get led status for psu 1
Aug 18 19:23:13.983319 sonic WARNING pmon#psud[37]: Failed to get led status for psu 2

Reproduced on SONiC.HEAD.745-dirty-20200818.151309

Staphylo commented 3 years ago

Thanks for your contribution, change LGTM. I'll be cherry-picking your change and making it go through our internal process.

Staphylo commented 3 years ago

I will be make a PR to https://github.com/Azure/sonic-buildimage/tree/master/ to update the submodules with your fix. This time I figured out a way to preserve the original Author name :)

vboykox commented 3 years ago

I will be make a PR to https://github.com/Azure/sonic-buildimage/tree/master/ to update the submodules with your fix. This time I figured out a way to preserve the original Author name :)

Thanks!

vboykox commented 3 years ago

Hi! When can we expect SONiC submodule to be updated?

Staphylo commented 3 years ago

Hi Volodymyr,

The PR has been merge ready for a week. I'm waiting for msft to pick it up https://github.com/Azure/sonic-buildimage/pull/5296 The engineer that usually takes care of it should be back from vacation this week so probably not much longer.